-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reformat chart templates #1439
Conversation
293875d
to
146b671
Compare
@dnskr lgtm , just once comment , why you decided to delete the |
I deleted |
this configmap is a place holder for for external rego policies for configAudit reports (empty by default), as built-in policies are used by default. it is used by our customers and users, Lets keep it for now. |
I'm ok to keep it for now. However, could you please explain how the ConfigMap
I found one more empty resource - Secret |
I agree that its can't be update via helm, however it is used by users who update it with in addition we have plan for it in the future therefore I prefer to keep it |
146b671
to
6e99d6d
Compare
Got it! I returned it back. |
@dnskr thank you for the contribution lgtm 🚀 |
Description
The PR reformats chart templates to common style with more readable blocks and indents.
ConfigMap
trivy-operator-policies-config
has been deleted, because it does not have any data.The PR does not change any functionality of the chart.
Similar PRs: apache/airflow#29917 apache/airflow#29941 apache/airflow#30312 minio/minio#16947 apache/superset#23681
Test
The following command prints same (minor differences) output before and after changes:
helm template test deploy/helm
Checklist